sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5771652404
@rusackas both of your points were already in before your last pass, so nothing new was needed for them: the omitted-key read in d16ddd8, and the non-dataset guard in 5ce70d6, where `isinstance(orm_datasource, SqlaTable)` short-circuits ahead of `table_name`/`is_virtual` (covered by `test_save_of_non_dataset_datasource_skips_table_check`, whose mock is specced to a query's attribute surface so a regression raises rather than passing silently). One docs-only commit on top in 7ecbbe4, no behaviour change: `_repoints_table`'s virtual short-circuit is only sound because the caller has already established the result is physical, so the docstring now states that precondition instead of leaving it 60 lines away at the call site. On the red CI: `babel-extract` and the `check_pot_drift` unit test (and the two required gates aggregating it) all fail on the same `messages.pot` drift, for strings in `superset/dashboards/api.py` and the alert/report paths. It reproduces on master and this branch adds no translatable strings, so it needs a separate regeneration PR rather than an unrelated `.pot` commit here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
