sha174n commented on PR #44080: URL: https://github.com/apache/superset/pull/44080#issuecomment-5779447469
@rusackas both points you raised are already in and unchanged: the omitted-key read in d16ddd8, and the non-dataset guard in 5ce70d6 (`isinstance(orm_datasource, SqlaTable)` short-circuits ahead of `table_name`/`is_virtual`). Correction on my earlier CI note: the `messages.pot` drift was inherited from the commit this branch was based on, and master has since regenerated the template. Merged master in fb3678d and the drift check passes locally, so `babel-extract` and `check_pot_drift` should be green here without a separate branch. One cleanup commit on top in 8448ff6, no behaviour change: the target database is resolved inside the branch that reads it rather than eagerly in an `else`, so a plain column/metric save no longer lazy-loads a `Database` row it discards, and six blank lines left behind by an earlier import move are dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
