fitzee commented on code in PR #44627:
URL: https://github.com/apache/superset/pull/44627#discussion_r4101653439
##########
docs/src/components/databases/DatabasePage.tsx:
##########
@@ -492,6 +492,30 @@ const DatabasePage: React.FC<DatabasePageProps> = ({
database, name }) => {
);
};
+ // Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
+ const renderExtendedAggregations = () => {
+ const aggregations = database.extended_aggregations;
Review Comment:
Minor: The new aggregate-support card disappears in fallback docs builds.
The docs verification workflow builds without Superset's Python dependencies,
invoking the AST fallback generator. That path never emits
`extended_aggregations`; its diagnostics merge also discards this field from
downloaded artifacts. Reproduced: all 75 generated database entries lacked the
field, causing this guard to hide every new card. Update the fallback generator
to populate the field and test the generated output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
