bito-code-review[bot] commented on code in PR #44627:
URL: https://github.com/apache/superset/pull/44627#discussion_r4102034273
##########
docs/src/components/databases/DatabasePage.tsx:
##########
@@ -492,6 +492,30 @@ const DatabasePage: React.FC<DatabasePageProps> = ({
database, name }) => {
);
};
+ // Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
+ const renderExtendedAggregations = () => {
+ const aggregations = database.extended_aggregations;
+ if (!aggregations || Object.keys(aggregations).length === 0) return null;
+
+ return (
+ <Card title="Extended Aggregate Functions" style={{ marginBottom: 16 }}>
+ <Text type="secondary" style={{ display: 'block', marginBottom: 8 }}>
+ The base aggregates (SUM, COUNT, AVG, MIN, MAX, COUNT DISTINCT) are
+ supported everywhere; these are opt-in per engine.
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing i18n translation</b></div>
<div id="fix">
The Card title and the explanatory `Text` are hardcoded English strings.
BITO.md adaptive rule 6516 requires user-facing labels to go through a
translation function. The docs site has no i18n wiring yet, so introduce the
standard helper (e.g., Docusaurus `translate`/`useTranslate`) and wrap both
strings.
</div>
</div>
<small><i>Code Review Run #22af7f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
