bito-code-review[bot] commented on PR #44701:
URL: https://github.com/apache/superset/pull/44701#issuecomment-5845473842
<!-- Bito Reply -->
The flagged issue is correct. The current implementation in the PR
explicitly floors the date to the second by setting milliseconds to zero, which
causes distinct timestamps within the same second to be formatted identically,
losing sub-second precision.
To resolve this while still avoiding the millisecond tier for axis-boundary
noise, you should remove the forced flooring and instead configure the
formatter to ignore sub-second precision only when it is not explicitly
required. A better approach is to ensure the formatter's adaptive logic does
not trigger the millisecond tier for these specific boundary labels, or to use
a format that does not include milliseconds by default.
Since there are no other comments in this PR, no further actions are
required.
**superset-frontend/plugins/plugin-chart-echarts/src/utils/formatters.ts**
```
if (!timeGrain) {
return new TimeFormatter({
id: SMART_DATE_ID,
label: baseFormatter.label,
formatFunc: (date: Date) => baseFormatter(date),
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
