rusackas commented on PR #44701: URL: https://github.com/apache/superset/pull/44701#issuecomment-5883178440
Thanks for the writeup on the root cause here, @kokhlo, that's a solid RCA. One thing before this merges though: codeant's still-open thread on `formatters.ts` has a point that bito's own follow-up comment raised too. Falling through to the grain-aware wrapper zeroes milliseconds for every tick in the no-grain path, not just the padded axis-boundary label that was actually broken, so a real ungrained series with genuine sub-second timestamps would now render distinct ticks identically. Feels like the fix should target the boundary label specifically rather than flooring every tick. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
