kokhlo commented on PR #44701: URL: https://github.com/apache/superset/pull/44701#issuecomment-5904776336
Rebased onto current `master` — the `requires:rebase` label and the conflict are both gone (`mergeable: true`). The one hunk that needed a decision was in the test file: `master` had added two `createSpacedXAxisFormatter` tests for the new `showAllLabels` parameter in the same region my regression test landed. I kept both — upstream's two tests and the sub-second one — so nothing upstream is lost and the fix keeps its own coverage. Diff vs `master` is unchanged: `formatters.ts` +5/-5, `formatters.test.ts` +11/-0. The two commits are the same two as before, only rebased (`cc5da15`, `9cf2b29`). `formatters.test.ts` suite: 27/27 green, the whole `plugin-chart-echarts/test/utils/` directory 238/238. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
