kokhlo commented on PR #44701: URL: https://github.com/apache/superset/pull/44701#issuecomment-5858024573
Valid point — verified the duplication is exact: with `timeGrain` undefined no `TimeGranularity` branch matches, so the wrapper's fall-through already zeroes milliseconds and calls `baseFormatter` on the floored date, byte-identical to the removed early return. Rather than extracting a shared helper for two consecutive branches in one function, dropped the early return in 9023d01 and let the no-grain case fall through the existing wrapper (the comment there now explains why). The regression test is unchanged and still pins the behavior; full `formatters.test.ts` 24/24 locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
