rusackas commented on PR #44699: URL: https://github.com/apache/superset/pull/44699#issuecomment-5883836285
Thanks for tackling this, @hainenber! One thing before this can merge, though. Looks like `set-lang-matrix` builds the `lang_matrix` string but never writes it to `$GITHUB_OUTPUT`, just echoes it to the log. So `needs.changes.outputs.lang_matrix` will come through empty, and `fromJson()` on that in `analyze`'s matrix is going to blow up the first time a PR actually touches python or JS. This PR's own CI didn't catch it since it only touches workflow yaml, so `analyze` never ran to exercise that path. Could you fix that and test against a branch that actually changes python or JS files, so we know the matrix comes out right before this lands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
