sadpandajoe commented on code in PR #44699:
URL: https://github.com/apache/superset/pull/44699#discussion_r4139973247
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -56,7 +70,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- language: ["python", "javascript"]
+ language: ${{ fromJson(needs.changes.outputs.lang_matrix) }}
Review Comment:
On a push containing multiple commits, the change detector only compares the
final commit with its parent, so a Python change earlier in the push can be
omitted when the tip only changes frontend code; this matrix then skips the
Python scan, and the removed schedule no longer catches it later. Could this
derive changed files from the push's full before-to-after range instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
