aminghadersohi commented on PR #44710: URL: https://github.com/apache/superset/pull/44710#issuecomment-5884316041
Addressed the remaining review-body suggestions in 76a1857619fefb632c383d670332d47f01d15c39: - Bito #a04cf0, duplicate endpoint derivation: `get_oauth2_authorization_uri` now delegates to `resolve_oauth2_client_info` instead of deriving the authorize endpoint itself. - Bito #a04cf0, missing explicit token URI case: `test_get_oauth2_config_databricks_derives_missing_endpoints` gained an explicit `token_request_uri` case and asserts it wins. - Bito #4466c1, type annotation mismatch: the Databricks `resolve_oauth2_client_info` override now takes and returns `Any`, which matches its non-dict passthrough. - Bito #4466c1, non-dict client_info crash: fixed in cb173945d87ae660264db586beaa621920176f69 (`test_update_oauth2_malformed_client_info_purges_tokens`). 76a1857 also covers the unresolvable-host fallback on update (`test_update_oauth2_unresolvable_endpoints_purges_tokens`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
