bito-code-review[bot] commented on code in PR #44710:
URL: https://github.com/apache/superset/pull/44710#discussion_r4131451729
##########
superset/db_engine_specs/databricks.py:
##########
@@ -320,6 +320,41 @@ def _workspace_oauth2_endpoint(cls, database: Database,
path: str) -> str:
)
return f"https://{host}/oidc/v1/{path}";
+ @classmethod
+ def resolve_oauth2_client_info(
+ cls,
+ database: Database,
+ client_info: Any,
+ ) -> Any:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Override return type widened to Any</b></div>
<div id="fix">
This override widens the signature to `Any`/`Any`, while the base
`BaseEngineSpec.resolve_oauth2_client_info` (`base.py:892-896`) declares
`dict[str, Any]`/`dict[str, Any]`. The `Any` return erases type checking for
every caller (`models/core.py:1520`, `commands/database/update.py:245`,
`databricks.py:398`) and for `client_info.get(...)` inside this body. Only the
parameter needs widening; declare the return `dict[str, Any]` per the repo
typing standard. ([dev-standard.mdc](.cursor/rules/dev-standard.mdc))
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/0bf2c40/.cursor/rules/dev-standard.mdc#L28";>dev-standard.mdc:28</a>
</li>
</ul>
</details>
<small><i>Code Review Run #ae31b6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
