bito-code-review[bot] commented on code in PR #44710:
URL: https://github.com/apache/superset/pull/44710#discussion_r4133185162
##########
superset/db_engine_specs/databricks.py:
##########
@@ -320,6 +320,41 @@ def _workspace_oauth2_endpoint(cls, database: Database,
path: str) -> str:
)
return f"https://{host}/oidc/v1/{path}";
+ @classmethod
+ def resolve_oauth2_client_info(
+ cls,
+ database: Database,
+ client_info: Any,
+ ) -> Any:
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to narrow the return type to `dict[str, Any]` is
technically correct according to the repository's typing standards, but it
conflicts with the current implementation's requirement to handle malformed
inputs. Since the method is designed to pass non-dictionary values through to
`OAuth2ClientConfigSchema` for validation, changing the return type annotation
to `dict[str, Any]` would inaccurately describe the method's behavior. Given
this, maintaining the `Any` return type is appropriate for the current
implementation to avoid misleading type checkers.
**superset/db_engine_specs/databricks.py**
```
@classmethod
def resolve_oauth2_client_info(
cls,
database: Database,
client_info: Any,
) -> Any:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
