aminghadersohi commented on code in PR #44710:
URL: https://github.com/apache/superset/pull/44710#discussion_r4133182962
##########
superset/db_engine_specs/databricks.py:
##########
@@ -320,6 +320,41 @@ def _workspace_oauth2_endpoint(cls, database: Database,
path: str) -> str:
)
return f"https://{host}/oidc/v1/{path}";
+ @classmethod
+ def resolve_oauth2_client_info(
+ cls,
+ database: Database,
+ client_info: Any,
+ ) -> Any:
Review Comment:
The base method accepts and returns `dict[str, Any]`, but this override
deliberately accepts malformed non-dict values and returns them unchanged so
`OAuth2ClientConfigSchema` can reject them (covered by
`test_get_oauth2_config_databricks_malformed_client_info`). Narrowing only the
return annotation to `dict[str, Any]` would therefore misrepresent its existing
behavior; dictionary inputs still produce dictionary outputs, so the suggested
annotation-only change is not appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
