aminghadersohi commented on PR #44746: URL: https://github.com/apache/superset/pull/44746#issuecomment-5908590037
Review follow-up: - rebenitez1802's approved review (5356562885): the complete body confirms the earlier feedback is resolved; no further change requests. - Bito's duplicated request-key suggestion (5897718375): addressed in 09179a33aebd0318606e070e6979900651a75eed. Both inventory tests use `_request_key(name)`, with a parameterized regression test covering all four chart tools. Merged Apache master in 7645c1c01f6051b4c2bdcf3925091658213e2b41 without rewriting history. The sole conflict was `UPDATING.md`; both the MCP upgrade notes and master's upgrade notes were retained. #44744 remains open, so no alternative histogram/waterfall implementation required adaptation. Validation: MCP unit suite **6,206 passed, 4 skipped**, using the repository-required FastMCP 3.4.7 and local `superset-core/src` on `PYTHONPATH`. The initial run with outdated FastMCP 3.4.2 had three catalog middleware signature failures; all pass with 3.4.7. Pre-commit passed on all 35 PR-changed files, including mypy and pylint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
