aminghadersohi commented on PR #44746: URL: https://github.com/apache/superset/pull/44746#issuecomment-5877600285
Addressed all four items in 5039119139845090d68418d91aa93153dc86ab8e: 1. **Empty-result flag:** gates saved previews before plugin dispatch, including the generic renderer; Bubble, Treemap, Gauge and Histogram opt in alongside Gantt. Regression run before the fix: 7 failed, 2 passed; all pass after. 2. **Histogram documentation:** added empty→spec behavior to the PR description, MCP docs and UPDATING.md. 3. **AST guard:** scans whole library/tool modules and structurally checks comparisons, dictionary keys and lookups, including aliases. Exact pre-existing helper/rendering/metadata expressions are pinned as a counted baseline, not function exemptions; added evasion regressions. 4. **HAVING comment:** distinguishes frontend adhoc HAVING parity from MCP's top-level `having` support. Chart MCP tests: 2,648 passed, 3 skipped; final contract suite: 464 passed. Pre-commit passed across all 35 PR-changed files, including mypy. The master conflict was already cleared: verified MERGEABLE at 4d952ec9; no merge needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
