aminghadersohi commented on PR #44746: URL: https://github.com/apache/superset/pull/44746#issuecomment-5910108349
Checked both September 28 Bito review bodies against the head. Closed in 56f5165dce: - **Duplicated registry scan; Redundant getattr fallback:** one scan with direct attribute access, preserving global native-over-additional priority and insertion-order ties; regression tests cover both registration orders. - **Missing series_columns:** each mixed-timeseries query carries its own grouping. - **Undocumented inline import; Undocumented local imports; Missing docstrings on hooks; Missing proxy docstring; Inline import violates rule; Cryptic docstring on proxy get:** documented deferred imports/hooks, hoisted get_column_name, clarified proxy wording. - **duplicated column resolution; magic default bin count:** consume the resolved histogram column and share the schema's bin default. - **Generic hook, Gantt-specific catch:** handle the protocol's ValueError while preserving the Gantt-specific response. - **Dead fallback branches:** consolidate default result metadata selection without changing responses. - **ignored param, empty columns; duplicate viz-type literal:** resolve trendline columns in the fields hook and reuse TRENDLINE_VIZ_TYPE. - **Inconsistent disabled-plugin policy:** saved table metric appends retain disabled-plugin contracts. - **Missing tests for fallback dispatch:** saved funnel, sankey/radar rejection, and generic fall-through tests added. - **Missing local type annotations:** annotate text/grown. - **Fragile type fallback; Shared mutable schema dict; Discriminator name coupling:** document Annotated inputs, correctly unwrap single models, deep-copy annotations, and share the discriminator constant. - **Silent ValidationError path** (both handlers): add diagnostic warnings. - **Bool row_limit bypasses fallback:** reject booleans in the shared compile-limit helper. Other body-only items: - **Dead plugin flag:** already fixed by 5039119139; preview generation consumes allows_empty_result, with contract tests. - **Unreachable rebind fallback:** not dead globally; plugins inheriting the base merge hook return None and need the generic dataset-rebind fallback. Retained. - **Disallow dynamic typing (Any) in public API:** heterogeneous Python configuration/form-data/query-result payloads intentionally use Any; the frontend TypeScript prohibition does not apply. Retained. Previously resolved inline items remain closed: disabled-plugin config completion, Gantt ValueError, and unguarded Treemap int() in 49b2e0a201; tooltip_metrics coverage and funnel stage ValueError in 21f20f09ec. “Magic numbers encode limit policy” and “Inconsistent mock pattern” retain their documented dispositions in the resolved threads. Filtered body suggestions: Treemap/Gauge compile-limit duplication was already removed by eb08fb8ead; per-test plugin-filter monkeypatches intentionally isolate test state. Validation: chart unit suite plus chart tool inventory: **2708 passed, 3 skipped**. Pre-commit on all touched files passed, including mypy and pylint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
