aminghadersohi commented on PR #44746: URL: https://github.com/apache/superset/pull/44746#issuecomment-5894823441
Retest #2: all three reported oversized chart tools are already covered by the shared compact chart-config annotation at the PR head; no additional production compaction is needed. Measured complete definitions as UTF-8 compact JSON (not just inputSchema, and without subtracting the chart-type enum). Native search definitions are normalized through MCP Tool validation and the gateway's metadata alias / exclude_unset serialization; direct tools/list retains output schemas and full descriptions: | Tool | Reporter-observed before | PR head native search | PR head direct catalog | | --- | ---: | ---: | ---: | | update_chart_preview | 112,956 B | 2,004 B | 3,551 B | | generate_explore_link | 106,800 B | 1,837 B | 8,157 B | | update_chart | 114,991 B | 4,077 B | 26,769 B | The before values are the reporter's measurements, not a reproduction against a customer workspace. A single-item gateway page adds two bytes for brackets. Added regression tests pinning the entire page below 100,000 bytes for both catalog paths and all four chart tools. Expanded FastMCP invalid-per-type-field validation coverage to all four request models; no runtime validation was weakened. Rechecked @rebenitez1802's change-request review and threads: the empty-result flag gates both plugin and generic rendering; all five intentional empty renderers opt in; Histogram's behavior is documented in UPDATING.md and the MCP docs; the AST guard scans whole modules and structurally checks comparisons/dictionary keys/get operands with mutation regressions; Histogram's comment explicitly distinguishes MCP top-level having support. The earlier master conflict is resolved and the PR is mergeable, so no additional merge is needed. Validation: 507 focused inventory/contract tests passed; branch-scoped pre-commit (including mypy and pylint) passed apart from a formatting auto-fix, followed by a clean staged pre-commit run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
