codeant-ai-for-open-source[bot] commented on code in PR #44834: URL: https://github.com/apache/superset/pull/44834#discussion_r4149480786
########## superset-core/src/superset_core/semantic_layers/metadata.py: ########## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Optional provider metadata acquisition and host publication interfaces.""" + +from __future__ import annotations + +from abc import ABC, abstractmethod +from collections.abc import Callable +from dataclasses import dataclass, field +from typing import Any, get_args, Literal, Protocol, TypeAlias + +# The host passes a finite absolute time.monotonic() deadline in this process. +CatalogLoader: TypeAlias = Callable[[float], str] +MetadataRefreshErrorCategory: TypeAlias = Literal[ + "unsupported", + "configuration", + "in_progress", + "configuration_changed", + "upstream", + "invalid_payload", + "deadline", + "unavailable", + "indeterminate", +] + + +@dataclass(frozen=True) +class CatalogSnapshot: + """Carry one validated observation and its captured cache identity. + + The provider supplies canonical JSON in payload. The host assigns a nonempty, + opaque, scope-qualified cache_token for each successful publication, including + unchanged discovery. observed_at is a UTC RFC3339 source-observation time for + display, not a cache creation/expiry time or an ordering authority. + """ + + payload: str = field(repr=False) + cache_token: str = field(repr=False) + observed_at: str + + def __post_init__(self) -> None: + if not self.cache_token: + raise ValueError("Catalog cache token must not be empty") + Review Comment: **Suggestion:** `CatalogSnapshot` accepts non-string payloads, tokens, and timestamps, allowing malformed observations to reach consumers expecting the declared string contract. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Type error` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=47381b899f754675a0de75e61d5b878e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=47381b899f754675a0de75e61d5b878e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-core/src/superset_core/semantic_layers/metadata.py **Line:** 56:59 **Comment:** *Type Error: `CatalogSnapshot` accepts non-string payloads, tokens, and timestamps, allowing malformed observations to reach consumers expecting the declared string contract. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44834&comment_hash=c34a901dd7887dac0658543996e18634e36b3d5aada4a6261885efbd5180a923&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44834&comment_hash=c34a901dd7887dac0658543996e18634e36b3d5aada4a6261885efbd5180a923&reaction=dislike'>๐</a> ########## superset-core/src/superset_core/semantic_layers/metadata.py: ########## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Optional provider metadata acquisition and host publication interfaces.""" + +from __future__ import annotations + +from abc import ABC, abstractmethod +from collections.abc import Callable +from dataclasses import dataclass, field +from typing import Any, get_args, Literal, Protocol, TypeAlias + +# The host passes a finite absolute time.monotonic() deadline in this process. +CatalogLoader: TypeAlias = Callable[[float], str] +MetadataRefreshErrorCategory: TypeAlias = Literal[ + "unsupported", + "configuration", + "in_progress", + "configuration_changed", + "upstream", + "invalid_payload", + "deadline", + "unavailable", + "indeterminate", +] + + +@dataclass(frozen=True) +class CatalogSnapshot: + """Carry one validated observation and its captured cache identity. + + The provider supplies canonical JSON in payload. The host assigns a nonempty, + opaque, scope-qualified cache_token for each successful publication, including + unchanged discovery. observed_at is a UTC RFC3339 source-observation time for + display, not a cache creation/expiry time or an ordering authority. + """ + + payload: str = field(repr=False) + cache_token: str = field(repr=False) + observed_at: str + + def __post_init__(self) -> None: + if not self.cache_token: + raise ValueError("Catalog cache token must not be empty") + + +@dataclass(frozen=True) +class MetadataRefreshResult: + """Report a confirmed publication and its immutable observation. + + Unchanged compares discovery payloads, not complete upstream metric + definitions. Changed includes installation without a prior observation. + An indeterminate publication must raise an error instead of returning success. + """ + + status: Literal["changed", "unchanged"] + snapshot: CatalogSnapshot + + def __post_init__(self) -> None: + if self.status not in ("changed", "unchanged"): + raise ValueError("Unknown metadata refresh result status") + + +class MetadataRefreshError(Exception): + """Carry a validated failure category without vendor messages or credentials. + + Hosts must not expose exception cause chains. Providers translating sensitive + upstream exceptions should suppress their displayed chain with ``from None``. + """ + + def __init__(self, category: MetadataRefreshErrorCategory) -> None: + if category not in get_args(MetadataRefreshErrorCategory): + raise ValueError("Unknown metadata refresh error category") + self.category: MetadataRefreshErrorCategory = category + super().__init__(category) + + +class MetadataSnapshotStore(Protocol): + """Define host-owned publication for one authorized connection scope. + + The loader receives a finite absolute time.monotonic() deadline and acquires + and validates canonical JSON within that budget and any tighter provider limit. + The host sets one deadline before waiting or acquisition; providers must not + reset it for nested requests. An exhausted budget raises the deadline category + before further I/O. The deadline is process-local, never serialized or used + for cache expiry or publication ordering; it does not replace writer fencing. + The host owns expiry, writer fencing and publication confirmation. This + protocol does not provide storage, authorization or distributed coordination. + Host-only invalidation and cache inspection are outside the provider interface. + """ + + def read(self, fetch: CatalogLoader) -> CatalogSnapshot: + """Read a valid observation or perform bounded coordinated acquisition. + + Cold readers wait/re-read within a finite deadline or fail safely; they + must not silently use an obsolete local copy. Cache hits retain identity + and expiry. Return the payload and its identity from the same observation. + """ + ... + + def refresh(self, fetch: CatalogLoader) -> MetadataRefreshResult: Review Comment: **Suggestion:** The store and adapter APIs accept no caller deadline, so cold-reader waits and refresh acquisition cannot honor the request's remaining time budget. **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9d115efd2a0546768decdbc5e75194f1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9d115efd2a0546768decdbc5e75194f1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-core/src/superset_core/semantic_layers/metadata.py **Line:** 106:115 **Comment:** *Api Mismatch: The store and adapter APIs accept no caller deadline, so cold-reader waits and refresh acquisition cannot honor the request's remaining time budget. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44834&comment_hash=792d5cc29f9c8725b21f8cc7f850489764e64c18490481ef97c2f2073124d172&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44834&comment_hash=792d5cc29f9c8725b21f8cc7f850489764e64c18490481ef97c2f2073124d172&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
