codeant-ai-for-open-source[bot] commented on code in PR #44834: URL: https://github.com/apache/superset/pull/44834#discussion_r4151282005
########## superset-core/src/superset_core/semantic_layers/metadata.py: ########## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Optional provider metadata acquisition and host publication interfaces.""" + +from __future__ import annotations + +from abc import ABC, abstractmethod +from collections.abc import Callable +from dataclasses import dataclass, field +from typing import Any, get_args, Literal, Protocol, TypeAlias + +# The host passes a finite absolute time.monotonic() deadline in this process. +CatalogLoader: TypeAlias = Callable[[float], str] +MetadataRefreshErrorCategory: TypeAlias = Literal[ + "unsupported", + "configuration", + "in_progress", + "configuration_changed", + "upstream", + "invalid_payload", + "deadline", + "unavailable", + "indeterminate", +] + + +@dataclass(frozen=True) +class CatalogSnapshot: + """Carry one validated observation and its captured cache identity. + + The provider supplies canonical JSON in payload. The host assigns a nonempty, + opaque, scope-qualified cache_token for each successful publication, including + unchanged discovery. observed_at is a UTC RFC3339 source-observation time for + display, not a cache creation/expiry time or an ordering authority. + """ + + payload: str = field(repr=False) + cache_token: str = field(repr=False) + observed_at: str + + def __post_init__(self) -> None: + if not self.cache_token: + raise ValueError("Catalog cache token must not be empty") + Review Comment: ✅ **CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `fa0de7b`. Added runtime type checks for payload, cache_token, and observed_at, plus nonempty-value checks for the token and timestamp. <sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub> <!-- codeant-auto-resolve-reply --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
