AmoghAtreya commented on code in PR #44955: URL: https://github.com/apache/superset/pull/44955#discussion_r4187529823
########## superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx: ########## Review Comment: Resolved in teh latest commit. Table and AG Grid now run `normalizeColumnConfigKeys` in `transformProps` before reading `columnConfig[key]`, so a legacy `Time` entry is applied on render. I did not write the remapped object back on load, to avoid dirtying the chart and to keep a real/dropped `Time` column from being stored on `__timestamp`. ########## superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx: ########## Review Comment: Resolved in the latest commit. Table and AG Grid now run `normalizeColumnConfigKeys` in `transformProps` before reading `columnConfig[key]`, so a legacy `Time` entry is applied on render. I did not write the remapped object back on load, to avoid dirtying the chart and to keep a real/dropped `Time` column from being stored on `__timestamp`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
