aminghadersohi commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4179128013
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/transformProps.ts:
##########
@@ -66,30 +119,40 @@ function processScatterData(
categoryColumn,
]);
+ const parsedFixedRadius = parseMetricValue(fixedRadiusValue);
+
return spatialFeatures.map(feature => {
let scatterPoint: ScatterPoint = {
position: feature.position,
extraProps: feature.extraProps || {},
};
+ // Reserved source columns live in extraProps to protect computed geometry.
+ const getSourceValue = (column?: string): unknown =>
+ column
+ ? feature.extraProps && column in feature.extraProps
+ ? feature.extraProps[column]
+ : feature[column]
+ : undefined;
Review Comment:
Confirmed as a functional regression and fixed in
4f08115ecb5cb7b8e4493232ca7893fc8ecde693. The extraProps lookup uses
Object.prototype.hasOwnProperty.call, so inherited keys no longer mask the
source metric or dimension; own reserved-column values retain precedence.
Added eight Jest regression cases covering constructor, toString,
hasOwnProperty, and valueOf as metric labels and dimensions. All eight fail
before the fix; all 43 Scatter transform tests pass afterward. Pre-commit
passes on both touched files, including oxfmt, oxlint, custom rules, stylelint,
and frontend type checking. Standalone ESLint is blocked by local
ERR_MODULE_NOT_FOUND in eslint-plugin-theme-colors; this checkout uses oxfmt
rather than a Prettier hook.
The reproduced issue concerns chart rendering correctness; no
role/capability boundary violation is demonstrated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
