bito-code-review[bot] commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4181008262
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/transformProps.ts:
##########
@@ -106,16 +170,32 @@ export default function transformProps(chartProps:
ChartProps) {
const { spatial, point_radius_fixed, dimension } =
formData as DeckScatterFormData;
- // Check if this is a fixed value or metric
- const fixedRadiusValue = isFixedValue(point_radius_fixed)
- ? getFixedValue(point_radius_fixed)
- : null;
+ // Typed compatibility accepts preserved numeric-string fixed radii.
+ // Native charts interpret bare strings as saved metric names.
+ const legacyFixedRadius =
+ formData.mcp_geographic &&
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Undeclared form-data property access</b></div>
<div id="fix">
`formData.mcp_geographic` resolves only through `FormDataResidual`'s `[key:
string]: any` index signature — `DeckScatterFormData` (buildQuery.ts) never
declares it, so this new guard has no compile-time checking; a rename of the
hidden control would silently break it. Declare `mcp_geographic?: boolean;` on
`DeckScatterFormData` so this check and the line-194 branch are typed.
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/696f569/.cursor/rules/dev-standard.mdc#L16";>dev-standard.mdc:16</a>
</li>
</ul>
</details>
<small><i>Code Review Run #51cfc3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
