bito-code-review[bot] commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4181149678
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/transformProps.ts:
##########
@@ -106,16 +170,32 @@ export default function transformProps(chartProps:
ChartProps) {
const { spatial, point_radius_fixed, dimension } =
formData as DeckScatterFormData;
- // Check if this is a fixed value or metric
- const fixedRadiusValue = isFixedValue(point_radius_fixed)
- ? getFixedValue(point_radius_fixed)
- : null;
+ // Typed compatibility accepts preserved numeric-string fixed radii.
+ // Native charts interpret bare strings as saved metric names.
+ const legacyFixedRadius =
+ formData.mcp_geographic &&
Review Comment:
<!-- Bito Reply -->
The suggestion to declare `mcp_geographic?: boolean` on
`DeckScatterFormData` is appropriate. It provides compile-time type safety for
the property access, ensuring that any future changes to the hidden control's
name or type are caught by the type checker, which aligns with standard
development practices for maintaining robust form data structures.
**superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/transformProps.ts**
```
// Typed compatibility accepts preserved numeric-string fixed radii.
// Native charts interpret bare strings as saved metric names.
const legacyFixedRadius =
formData.mcp_geographic &&
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
