aminghadersohi commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4180889468
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/transformProps.ts:
##########
@@ -106,16 +170,30 @@ export default function transformProps(chartProps:
ChartProps) {
const { spatial, point_radius_fixed, dimension } =
formData as DeckScatterFormData;
- // Check if this is a fixed value or metric
- const fixedRadiusValue = isFixedValue(point_radius_fixed)
- ? getFixedValue(point_radius_fixed)
- : null;
+ // Legacy native controls store fixed radii as bare numeric strings.
+ const legacyFixedRadius =
+ typeof point_radius_fixed === 'string' &&
+ point_radius_fixed.trim() !== '' &&
+ Number.isFinite(Number(point_radius_fixed))
+ ? Number(point_radius_fixed)
Review Comment:
Fixed in 696f5698b5dabf1362d2617298525e156cb3f002: numeric-string
fixed-radius handling is limited to mcp_geographic charts, preserving native
saved-metric radii and labels with regression coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
