AmoghAtreya commented on code in PR #44955:
URL: https://github.com/apache/superset/pull/44955#discussion_r4191761235
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -390,6 +390,26 @@ describe('plugin-chart-table', () => {
expect(String(parsedDate)).toBe('2020-01-01 12:34:56');
expect(parsedDate.getTime()).toBe(1577882096000);
});
+
+ test('applies legacy Time column_config to the __timestamp column', () => {
Review Comment:
Added. Both table and AG Grid transformProps tests now use a datasource
column named `Time` that is absent from colnames, a result that includes
`__timestamp`, and `column_config: { Time: {...} }`, and assert `__timestamp`
does not pick up that config. `isEqualColumns` also compares datasource
column/metric names so the memoized `processColumns` path cannot reuse the
empty-datasource result from the legacy `Time` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
