AmoghAtreya commented on code in PR #44955:
URL: https://github.com/apache/superset/pull/44955#discussion_r4191741475
##########
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts:
##########
@@ -237,6 +239,11 @@ const processColumns = memoizeOne(function processColumns(
const columnsByName = new Map(
(props.datasource.columns ?? []).map(col => [col.column_name, col]),
);
+ const normalizedColumnConfig = normalizeColumnConfigKeys(
Review Comment:
Yes. `# revenue` made `Previous revenue` look like a translated Main slot,
so its config was rewritten onto `Main revenue`.
`normalizeColumnConfigKeys` now leaves keys that already match a result
column alone. Localized leftover keys such as `Principale revenue` still remap.
Added unit and Table/AG Grid `transformProps` coverage for this raw-mode shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
