AmoghAtreya commented on code in PR #44955: URL: https://github.com/apache/superset/pull/44955#discussion_r4188791774
########## superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx: ########## Review Comment: Thanks for catching that the control was still defaulting knownKeys to colnames. `mapStateToProps` now passes dataset `column_name` and `metric_name` values into this call, same as Table/AG Grid `transformProps`. A real/dropped `Time` column is no longer remapped onto `__timestamp`; an unrelated edit still drops that leftover key because it is outside colnames. Legacy alias keys still migrate when `Time` is not a known column or metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
