AmoghAtreya commented on code in PR #44955:
URL: https://github.com/apache/superset/pull/44955#discussion_r4191426399
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -701,6 +702,10 @@ const config: ControlPanelConfig = {
coltypes,
childColumnMap,
timeComparisonColumnMap,
+ knownKeys: getKnownColumnConfigKeys(
Review Comment:
Thank you, just resolved. With time comparison on, `colnames` had already
been expanded, so an ad hoc metric labelled `Time` was no longer in `knownKeys`.
Table and AG Grid now build `knownKeys` from the original query colnames
(`_colnames`) before that expansion. The control still unions those with the
expanded colnames, so comparison slots stay known and a `Time` metric is not
remapped onto `__timestamp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
