aminghadersohi commented on code in PR #44849:
URL: https://github.com/apache/superset/pull/44849#discussion_r4213140445
##########
superset/common/query_context_processor.py:
##########
@@ -257,7 +259,10 @@ def get_df_payload_result(
# This ensures sanitize_clause() is called and extras are
normalized
query_obj.validate()
- cache_key = self.query_cache_key(query_obj)
+ parent_cache_context: dict[str, Any] = {}
+ cache_key: str | None = self.query_cache_key(
+ query_obj, parent_cache_context=parent_cache_context
Review Comment:
Passing `parent_cache_context=` here turns `unit-tests` red: master's
`test_query_dataset_reexecutes_across_rollover[False|True]` doubles
`query_cache_key` with `QueryObject.cache_key`, which hashes the kwarg. Fix
that double (outside this diff): `side_effect=lambda query, **_:
query.cache_key()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
