sadpandajoe commented on code in PR #44849:
URL: https://github.com/apache/superset/pull/44849#discussion_r4213849660
##########
superset/mcp_service/semantic_layer/tool/get_table.py:
##########
@@ -653,9 +658,14 @@ async def get_table(
datasource_id = request.view_id
try:
- return await _run_get_table_query(
- request, ctx, is_builtin, datasource_id, datasource_type
- )
+ with (
+ metadata_operation()
+ if not is_builtin and metadata_refresh_enabled()
+ else nullcontext()
+ ):
+ return await _run_get_table_query(
Review Comment:
Thanks for confirming the running-loop boundary. Until it is resolved,
enabling refresh still makes `get_table` and `get_compatible_metrics` return an
internal error even with a warm catalog, and `list_metrics` swallows the same
failure in its per-view `except`, so it reports success with no metrics for a
participating view. Which execution boundary do you plan to take here, and can
the feature stay off for MCP clients (or these tools return an explicit
unsupported error) until it lands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
