mikebridge commented on code in PR #44849:
URL: https://github.com/apache/superset/pull/44849#discussion_r4213573819
##########
superset/common/query_context_processor.py:
##########
@@ -257,7 +259,10 @@ def get_df_payload_result(
# This ensures sanitize_clause() is called and extras are
normalized
query_obj.validate()
- cache_key = self.query_cache_key(query_obj)
+ parent_cache_context: dict[str, Any] = {}
+ cache_key: str | None = self.query_cache_key(
+ query_obj, parent_cache_context=parent_cache_context
Review Comment:
Good catch — fixed in
[16e864090b](https://github.com/apache/superset/commit/16e864090b7879b00de241f00c93ac830062433a)
(store
[d39709c172](https://github.com/apache/superset/commit/d39709c1728472e6e0f1ffbdb06a77c888623f4b)).
The production path computes and consumes the processor key in one place, so
the failure was the test fixture: it patched `query_cache_key` with
`QueryObject.cache_key`, which hashed the new `parent_cache_context` kwarg and
no longer matched the test's own `query.cache_key()` lookup. The fixture now
drops processor-only kwargs and hashes query identity the same way the lookup
does; all the rollover assertions are unchanged and the file passes (110) on
all three layers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
