tien238lnd commented on code in PR #45175:
URL: https://github.com/apache/superset/pull/45175#discussion_r4240176414
##########
superset/commands/datasource/list.py:
##########
@@ -121,31 +174,34 @@ def _resolve_connection_source_type(
if database_id is not None:
return "database"
elif semantic_layer_uuid is not None:
- # A semantic-layer connection selects only that layer's
- # (schema-less) views, so a dataset-only schema filter matches
+ # A semantic-layer connection selects only that layer's views,
+ # so a dataset-only filter (schema, editors, certified) matches
# nothing: the honest result is empty. Unlike an explicit
# Source="Semantic layer" selection (handled in
# _resolve_source_type), the user never picked a source type
# here, so the "explicit selection wins" rule does not apply.
- if schema_filter is not None:
+ if dataset_only:
Review Comment:
Fixed in ea063b8: the connection stage now also treats the physical/virtual
(`sql`) toggle as dataset-only, so a semantic-layer connection plus the toggle
resolves to an empty result instead of listing every view of the layer. Covered
by `test_run_semantic_layer_connection_with_sql_filter_returns_empty`.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
