codeant-ai-for-open-source[bot] commented on code in PR #45175:
URL: https://github.com/apache/superset/pull/45175#discussion_r4238698595
##########
superset/commands/datasource/list.py:
##########
@@ -121,31 +174,34 @@ def _resolve_connection_source_type(
if database_id is not None:
return "database"
elif semantic_layer_uuid is not None:
- # A semantic-layer connection selects only that layer's
- # (schema-less) views, so a dataset-only schema filter matches
+ # A semantic-layer connection selects only that layer's views,
+ # so a dataset-only filter (schema, editors, certified) matches
# nothing: the honest result is empty. Unlike an explicit
# Source="Semantic layer" selection (handled in
# _resolve_source_type), the user never picked a source type
# here, so the "explicit selection wins" rule does not apply.
- if schema_filter is not None:
+ if dataset_only:
Review Comment:
**Suggestion:** With a semantic-layer UUID and a SQL toggle, this check
misses the dataset-only filter; the connection selects views and silently drops
the SQL filter.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect condition
logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e49c1df010cc4c929d9fecaae4913ad6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e49c1df010cc4c929d9fecaae4913ad6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/datasource/list.py
**Line:** 183:183
**Comment:**
*Incorrect Condition Logic: With a semantic-layer UUID and a SQL
toggle, this check misses the dataset-only filter; the connection selects views
and silently drops the SQL filter.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45175&comment_hash=86e937616a4ee6eaf36b831bf891760334824c4e223e7dcd6d297c88e5d5fe6e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45175&comment_hash=86e937616a4ee6eaf36b831bf891760334824c4e223e7dcd6d297c88e5d5fe6e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
