EnxDev commented on code in PR #45175:
URL: https://github.com/apache/superset/pull/45175#discussion_r4256176115
##########
superset/commands/datasource/list.py:
##########
@@ -298,63 +362,79 @@ def _apply_sql_null_filter(
return type_filter, sql_filter
@staticmethod
- def _parse_filters(
- filters: list[dict[str, Any]],
- ) -> tuple[
- str, str | None, bool | None, str | None, int | None, str | None, str
| None
- ]:
+ def _parse_legacy_filter(
+ col: str, opr: Any, value: Any, current: dict[str, Any]
+ ) -> dict[str, Any]:
+ """Parse the columns the combined list supported from the start.
+
+ These stay lenient: an operator that is not the expected one is ignored
Review Comment:
This is the part I'd tighten. `schema` with any operator other than `eq`, or
`table_name` with `eq`, still comes back as an unfiltered list that looks
filtered, which is exactly the failure this PR removes for the new columns.
I'd make them strict too. If the #43829 tests pin the lenient behaviour a
follow-up is fine, but it deserves an issue so it doesn't get lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
