tien238lnd commented on code in PR #45175:
URL: https://github.com/apache/superset/pull/45175#discussion_r4267221789
##########
superset/commands/datasource/list.py:
##########
@@ -298,63 +362,79 @@ def _apply_sql_null_filter(
return type_filter, sql_filter
@staticmethod
- def _parse_filters(
- filters: list[dict[str, Any]],
- ) -> tuple[
- str, str | None, bool | None, str | None, int | None, str | None, str
| None
- ]:
+ def _parse_legacy_filter(
+ col: str, opr: Any, value: Any, current: dict[str, Any]
+ ) -> dict[str, Any]:
+ """Parse the columns the combined list supported from the start.
+
+ These stay lenient: an operator that is not the expected one is ignored
Review Comment:
Done in 38ee316: every column the combined list filters on now rejects an
operator it does not apply and a value it cannot read with the same 400 as
`/api/v1/dataset/` (`table_name` with `ct`, `schema` with `eq`, `sql` with
`dataset_is_null_or_empty`, `database` with `rel_o_m`, `source_type` and
`semantic_layer_uuid` with `eq`). The tests from #43829 that pinned the lenient
behavior now assert the 400, and the `UPDATING.md` note lists the operators.
The Datasets page only sends the expected operator for each column, and the
integration tests only send `eq` for `source_type` and `schema`.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
