aminghadersohi commented on PR #45232: URL: https://github.com/apache/superset/pull/45232#issuecomment-6138874004
Reviewed fe8719e7 against master after verifying the live head and green CI. - **MEDIUM — `superset/sql/execution/celery_task.py:512` (reviewed head):** A stop during result serialization or backend storage could still be overwritten by SUCCESS; a backend failure or exception could overwrite STOPPED with FAILED. Four regression cases failed before the fix. Closed by **24e6e6b69b**: re-check late stops, return a minimal STOPPED payload, preserve the recorded end time, and avoid flushing stale state or discarding normal pending result metadata. Validation: **624 tests passed** across Impala, cancellation validation, SQL Lab, SQL execution/Celery, Hive, Presto, chart cancellation, and MCP workers. Celery statement/branch coverage is **100%**. Pre-commit, including mypy, passed on all four branch-changed files. Added real SQLAlchemy checks for metadata preservation and timeout handling. Checked running/admission-queued live-cursor cancellation, stop/fetch boundaries, both earlier fixes, and unchanged chart/MCP HTTP cancellation. No other reproducible findings in the reviewed changes. Real-Impala acceptance was not run. Fix pushed to the designated fork branch. The PR remains draft with base master; CI is running at 24e6e6b69b. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
