aminghadersohi commented on PR #45232: URL: https://github.com/apache/superset/pull/45232#issuecomment-6143358347
Re-reviewed the full PR diff against master at `30afc2b0ecbb98e66ec3542d4c496221f74fd09f`, after verifying the live head. - **MEDIUM — Celery terminal metadata could still overwrite a committed stop.** A stop landing after the final status read but before the success/error/backend-failure commit could become SUCCESS or FAILED. Lazy relationship loads could also autoflush stale terminal metadata before the final check, overwriting the recorded stop time or status. Closed by **447eb1e57283d724e4fd9a68a3e72a7958e29ef3**: conditionally update the non-STOPPED row before flushing terminal metadata, suppress premature autoflush, and reload the winning stop with a locking read. Five regression cases using separate SQLAlchemy sessions failed before their fixes; successful pending metadata remains preserved. Verified the earlier fixes: atomic Impala STOPPED/early-cancel publication, running and admission-queued live-cursor cancellation without HTTP double-cancel, cancelled cursors not finalized as SUCCESS, late serialization/backend stops, and the stacktrace cancellation-metadata fixture. Chart/MCP HTTP cancellation remains unchanged. No other findings in the reviewed diff. Validation: **623 focused tests passed**; **2,330 SQL tests passed with 100% statement/branch coverage**. Pre-commit, including mypy, passed on all five PR-changed files. Real-Impala acceptance was not run. Fix pushed normally to the designated fork branch. Verified live head `447eb1e57283d724e4fd9a68a3e72a7958e29ef3`; the PR remains draft with base master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
