aminghadersohi commented on PR #45232: URL: https://github.com/apache/superset/pull/45232#issuecomment-6144316203
Reviewed the full diff against apache/superset master at `447eb1e57283d724e4fd9a68a3e72a7958e29ef3`, after verifying the live head matched the requested SHA. - **MEDIUM — Celery exception recovery could bypass the terminal stop guard.** The real `_get_query` in `execute_sql_task` autoflushed dirty worker state before `_handle_query_error` checked STOPPED. A concurrent soft time limit could overwrite STOPPED with TIMED_OUT; a backend exception could overwrite the recorded stop time and cancellation metadata. ORM loads during OAuth retry evaluation exposed the same problem. Three regression cases using independently committed SQLAlchemy sessions failed before the fix. Closed by **04cb0dad0f62706416af659faa8bc6f87be2b88b**: suppress implicit autoflush across task execution and error recovery, retaining explicit guarded commits. Eight regression/control cases verify stopped results and normal FAILED/TIMED_OUT behavior with the real query lookup. Rechecked Impala running/admission-queued live-cursor cancellation, synchronous stop/fetch handling, partial results, late serialization/backend stops, atomic SUCCESS/FAILED finalization, and the earlier fixes. Chart/MCP cancellation still makes a single HTTP request and does not use SQL Lab's preparation hook. No additional reproducible findings. Validation: - **651 focused tests passed**, including `pytest tests/unit_tests/sql_lab* tests/unit_tests/db_engine_specs/test_impala.py`, SQL execution/Celery, Impala pending/cancellation validation, Hive, Presto, chart cancellation, MCP workers, and stacktrace regressions. - **2,338 SQL tests passed**, with **100% statement/branch coverage**. - Chart/MCP Impala HTTP smoke probe passed with mocked RPCs. - Pre-commit, including mypy, passed on the two changed files and all five branch-changed files, using repository-pinned Ruff. - Real-Impala acceptance was not run. Pushed normally to the designated fork branch. Verified live head `04cb0dad0f62706416af659faa8bc6f87be2b88b`; draft state and master base are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
