aminghadersohi commented on PR #45232: URL: https://github.com/apache/superset/pull/45232#issuecomment-6142272605
CI diagnosis at `24e6e6b69b`: **PR-caused test-fixture failure**, not flaky/infra. - Checked the prior SQL coverage issue first. In https://github.com/apache/superset/actions/runs/38351128036/job/115143663607 the full suite failed before the SQL coverage gate, so that gate was skipped. The only failure was `test_new_handle_query_error_payload_includes_stacktrace_when_enabled`: 26,328 passed, one failed. - Latest master run https://github.com/apache/superset/actions/runs/38361381834 skipped Python tests. Latest master run that actually executed them, https://github.com/apache/superset/actions/runs/38357477723/job/115165985995 (`6d974e19c5`), passed 26,337 tests. Its JUnit artifact confirms all six stacktrace tests passed; SQL coverage was 100%. - Reproduced the failure locally: one failed, five passed. The new cancellation check reads `query.extra`, but the stacktrace fixture left it as a truthy `MagicMock`. That falsely selected STOPPED instead of the error/stacktrace path. Set the fixture metadata to `{}` and assert FAILED for both stacktrace settings. No production behavior changed. - Validation: 106 focused stacktrace/Impala/Celery tests passed; the full SQL gate passed 2,325 tests with 100% statement/branch coverage, including Celery. Pre-commit, including mypy, passed on all five branch-changed files using the repository-pinned Ruff version. Pushed `30afc2b0ecbb98e66ec3542d4c496221f74fd09f` to the designated fork branch; replacement CI is pending. The PR remains draft. No CI rerun or review request was made. Real-Impala acceptance remains outside this unit-test fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
