jprinet commented on code in PR #45217:
URL: https://github.com/apache/superset/pull/45217#discussion_r4257891670
##########
.github/workflows/superset-frontend.yml:
##########
@@ -92,10 +114,21 @@ jobs:
run: |
zstd -d < docker-image.tar.zst | docker load
+ - name: Setup Develocity for npm
+ id: develocity-npm
+ if: env.DEVELOCITY_ENABLED == 'true'
+ continue-on-error: true
+ uses: $/.github/actions/setup-develocity-npm
+ with:
+ develocity-access-key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+
- name: npm run test with coverage
+ env:
+ DEVELOCITY_DOCKER_ENV: ${{ steps.develocity-npm.outcome == 'success'
&& env.DEVELOCITY_DOCKER_ARGS || '' }}
Review Comment:
Good catch. The setup action now exports `agent-installed`, true only when
the agent package is on disk, and the container jobs gate the preload on that
instead of the step outcome (448db75014).
##########
.github/workflows/superset-e2e.yml:
##########
@@ -135,6 +144,12 @@ jobs:
node-version-file: "./superset-frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "superset-frontend/package-lock.json"
+ - name: Setup Develocity for npm
Review Comment:
Agreed. E2E now disables Develocity on `workflow_dispatch`, and
`setup-backend` only receives the key when Develocity is enabled, so a
dispatched PR or ref never sees it (448db75014).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
