sadpandajoe commented on code in PR #45217:
URL: https://github.com/apache/superset/pull/45217#discussion_r4259695958
##########
.github/workflows/superset-e2e.yml:
##########
@@ -135,6 +146,12 @@ jobs:
node-version-file: "./superset-frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "superset-frontend/package-lock.json"
+ - name: Setup Develocity for npm
+ if: env.DEVELOCITY_ENABLED == 'true'
Review Comment:
`DEVELOCITY_ENABLED` is an ordinary env value, so fork code can flip it on a
dispatch: with `pr_id` the fork's merge ref is checked out and its `setup.py`
runs during `uv pip install -e .` in Setup Python, before this step. That code
can append `DEVELOCITY_ENABLED=true` to `$GITHUB_ENV`, which makes this `if:`
pass, and the step is then handed `secrets.DEVELOCITY_ACCESS_KEY`, so the
long-lived key reaches the setup action's environment with fork-controlled
npm/config settings in play. Should this step (and the matching one in the
second job) check `github.event_name != 'workflow_dispatch'` directly instead
of relying on the env flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
