jprinet commented on code in PR #45217:
URL: https://github.com/apache/superset/pull/45217#discussion_r4259882429
##########
.github/workflows/superset-e2e.yml:
##########
@@ -135,6 +146,12 @@ jobs:
node-version-file: "./superset-frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "superset-frontend/package-lock.json"
+ - name: Setup Develocity for npm
+ if: env.DEVELOCITY_ENABLED == 'true'
Review Comment:
Good catch, thanks! `$GITHUB_ENV` does override the job-level flag, and on a
dispatch `./.github/actions/setup-develocity-npm` itself comes from the
checked-out code, so the step must never run there. Fixed in 758e972e: both
steps now check `github.event_name != 'workflow_dispatch'` in their `if:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
