aminghadersohi commented on PR #45283: URL: https://github.com/apache/superset/pull/45283#issuecomment-6194076301
At ae017e6f703bf13a605d4e4b98d7a8c36b801b15, `test_stop_at_target_commit_is_serialized` passes all four MySQL REPEATABLE READ / READ COMMITTED cases. Removing `with_for_update` makes both worker-winning parameters fail with `DID NOT RAISE TimeoutError`. A repeated Stop on an already-stopped query no longer writes `QUERY_EARLY_CANCEL_KEY`; this is harmless because status STOPPED is checked first. `test_stop_query_commits_stop_with_early_cancel` covers the flag behavior. Validation: `pytest tests/unit_tests/daos/ tests/unit_tests/sql/` — 2,618 passed, 2 skipped; PostgreSQL `-k stop` — 116 passed; `pre-commit run` — passed. Full MySQL module — 7 passed, 1 TLS certificate-validation failure in `test_require_mysql_tls_connects_with_verified_tls`, also reproduced using the original-head test file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
