aminghadersohi commented on PR #45283: URL: https://github.com/apache/superset/pull/45283#issuecomment-6193694861
Repeated Stop remains accepted, preserves end_time, and no longer re-cancels the engine. MySQL 8.0 REPEATABLE READ commit-boundary tests pass for both Stop-winning and worker-winning cases; the MySQL documentation claim is tested. Commit: a3015cf05aa7db63e6762fba8aff226c618d053e. Tests: `test_stop_acceptance_survives_post_commit_failure`, `test_repeated_stop_cancels_postgres_only_once`, and MySQL `test_stop_at_target_commit_is_serialized`. Before/revert: 6 unit + 4 Postgres failures; after: 2,709 unit + 118 Postgres + 2 MySQL passes (2 unit skips). `pre-commit run` passes, including mypy. Siblings checked: - `superset/daos/query.py:87` — fixed in a3015cf05a (shared Stop finalization). - `superset/sql/execution/executor.py:1449` — fixed in a3015cf05a (same helper). - `superset/sql/execution/celery_task.py:446` — not affected: records stopped metadata without issuing engine cancellation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
