aminghadersohi commented on PR #45283: URL: https://github.com/apache/superset/pull/45283#issuecomment-6201793672
Merge-order note for https://github.com/apache/superset/pull/45232 : this PR first, then that PR after merging `origin/master` into its branch. The shared stop-before-engine-cancel design belongs here; I am keeping the other PR scoped to Impala routing instead of duplicating the redesign. Remaining: the later branch is not yet stacked on this design. A trial merge reports conflicts in `UPDATING.md`, `daos/query.py`, `impala.py`, `celery_task.py` and `test_celery_task.py`. Whether the shared design's HTTP-only Impala path avoids both reported failures without a polling trade-off still needs real-Impala acceptance. Scope-reduction details are in https://github.com/apache/superset/pull/45232#pullrequestreview-5537157969 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
