codeant-ai-for-open-source[bot] commented on code in PR #45495:
URL: https://github.com/apache/superset/pull/45495#discussion_r4319617555
##########
superset-frontend/src/constants.ts:
##########
@@ -83,6 +83,10 @@ export const URL_PARAMS = {
name: 'permalink_key',
type: 'string',
},
+ activeTabs: {
+ name: 'active_tabs',
+ type: 'string',
+ },
Review Comment:
Yes. `active_tabs` is dashboard presentation state, not a chart query
parameter, so it should be excluded by the set used for
`extractUrlParams('regular')`. Adding it only to
`RESERVED_DASHBOARD_URL_PARAMS` won’t help unless that extractor consults the
list. A regression test should confirm `active_tabs` is omitted from chart
`url_params` while remaining in the dashboard URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
