justinpark commented on PR #45495:
URL: https://github.com/apache/superset/pull/45495#issuecomment-6303522004
Thanks @sadpandajoe, addressed in 813ce84:
- Builder now waits for this load's hydration, so the header can't init from
stale state.
- The hash is dropped once a tab change leaves its path, so a shared link
reopens the selected tab.
- An explicit `active_tabs` with no hash/focused chart clears the stale
click path.
- Added a test with a state-updating hydration asserting the URL follows tab
changes.
@rusackas Thanks for checking. On the application-root point: the hook
matches against the router's `history.location.pathname`, which already has the
`<Router basename={applicationRoot()}>` prefix stripped, so
`/dashboard/:idOrSlug/` matches on root and custom-prefix deployments alike
(unlike FilterBar, which reads `window.location`). The hook tests already cover
`''`, `/analytics` and `/superset` roots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
