codeant-ai-for-open-source[bot] commented on code in PR #45609:
URL: https://github.com/apache/superset/pull/45609#discussion_r4345007284
##########
.github/workflows/superset-frontend.yml:
##########
@@ -207,8 +207,63 @@ jobs:
docker run --rm $TAG bash -c \
"npx playwright install-deps && npx playwright install chromium &&
npm run test-storybook"
+ # Chromatic used to live in its own workflow and build a second copy of the
+ # CI image (about 50 s on a warm layer cache, 7 minutes after a lockfile
+ # change). It now reuses the image frontend-build uploads, like the other
+ # jobs here. Every step is skipped when the project token is absent
+ # (forks), which is what the old workflow did too.
+ chromatic:
+ needs: frontend-build
+ if: needs.frontend-build.outputs.should-run == 'true'
Review Comment:
**Suggestion:** On a multi-commit push, `fetch_changed_files_push` checks
only the tip commit against its parent. If an earlier commit changes frontend
files, this gate skips Chromatic even though the old path filter ran.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=111b98c8b3484306ab9d9e94ce67fcad&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=111b98c8b3484306ab9d9e94ce67fcad&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/superset-frontend.yml
**Line:** 217:217
**Comment:**
*Incorrect Condition Logic: On a multi-commit push,
`fetch_changed_files_push` checks only the tip commit against its parent. If an
earlier commit changes frontend files, this gate skips Chromatic even though
the old path filter ran.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45609&comment_hash=2b185fae366acb265fcce2862139171dd3a930bcaa2317e0cc661df55ccf939f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45609&comment_hash=2b185fae366acb265fcce2862139171dd3a930bcaa2317e0cc661df55ccf939f&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
