codeant-ai-for-open-source[bot] commented on code in PR #45609:
URL: https://github.com/apache/superset/pull/45609#discussion_r4353561655
##########
.github/workflows/superset-frontend.yml:
##########
@@ -207,8 +207,63 @@ jobs:
docker run --rm $TAG bash -c \
"npx playwright install-deps && npx playwright install chromium &&
npm run test-storybook"
+ # Chromatic used to live in its own workflow and build a second copy of the
+ # CI image (about 50 s on a warm layer cache, 7 minutes after a lockfile
+ # change). It now reuses the image frontend-build uploads, like the other
+ # jobs here. Every step is skipped when the project token is absent
+ # (forks), which is what the old workflow did too.
+ chromatic:
+ needs: frontend-build
+ if: needs.frontend-build.outputs.should-run == 'true'
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag tip-vs-parent changed-file detection in this workflow as
missing earlier commits; pushes to master are squash merges, so the tip
contains the whole change.
**Applied to:**
- `.github/workflows/superset-frontend.yml`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
